From a4d360b36cc146512d790faa968b994d9a640cfb Mon Sep 17 00:00:00 2001 From: Willian Molinari Date: Fri, 16 Jun 2017 16:08:08 -0300 Subject: [PATCH] Add a deadline for new PR on CONTRIBUTION (#1459) We are trying to avoid having hundreds of open Pull Requests. By using this rule we may close old PRs. --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- CONTRIBUTING.md | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index de01c8b3..5904dea7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,6 +17,6 @@ Very good coverage - [ ] I have added godoc link to the repo and to my pull request - [ ] I have added coverage service link to the repo and to my pull request - [ ] I have added goreportcard link to the repo and to my pull request -- [ ] I have read [Contribution guidelines](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#contribution-guidelines) and [Quality standard](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#quality-standard). +- [ ] I have read [Contribution guidelines](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#contribution-guidelines), [maintainers note](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#maintainers) and [Quality standard](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#quality-standard). Thanks for your PR, you're awesome! :+1: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 332f25ef..6d6fa706 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -23,7 +23,7 @@ If you removed our PR template you can find it [here](https://github.com/avelino ## Quality standards -To be on the list, project repositories should adhere to these quality standards (http://goreportcard.com/report/**github_user**/**github_repo**): +To be on the list, project repositories should adhere to these quality standards (http://goreportcard.com/report/ **github_user** / **github_repo**): - Code functions as documented and expected - Generally useful to the wider community of Go programmers @@ -39,6 +39,10 @@ To be on the list, project repositories should adhere to these quality standards To make sure every PR is checked, we have [team maintainers](MAINTAINERS). Every PR MUST be reviewed by at least two maintainers before it can get merged. +The maintainers will review your PR and notify you and tag it in case any +information is still missing. They will wait 8 days for your interaction, after +that the PR will be closed. + ## Reporting issues